Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Every now and then I can provide good feedback when I pull down the branch in question, test it locally, and try to think of a way to break it. Rarely do I have that kind of time.


A code review is not about testing the functionality or finding bugs. It is about sanity checking the design (although in a welk performing team the design should never come as a surprise), complexity, readability, and test coverage.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: